jscheffl commented on code in PR #36755:
URL: https://github.com/apache/airflow/pull/36755#discussion_r1518978720


##########
scripts/ci/images/ci_start_arm_instance_and_connect_to_docker.sh:
##########
@@ -20,7 +20,7 @@ SCRIPTS_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)"
 WORKING_DIR="/tmp/armdocker"
 INSTANCE_INFO="${WORKING_DIR}/instance_info.json"
 ARM_AMI="ami-0e43196369d299715"  # AMI ID of latest arm-docker-ami-v*
-INSTANCE_TYPE="m7g.2xlarge"  # m7g.2xlarge -> 8 vCPUS 32 GB RAM
+INSTANCE_TYPE="m7g.xlarge"  # m7g.2xlarge -> 8 vCPUS 32 GB RAM

Review Comment:
   Comment is not matching anymore
   ```suggestion
   INSTANCE_TYPE="m7g.xlarge"  # m7g.xlarge -> 4 vCPUS 16 GB RAM
   ```



##########
Dockerfile.ci:
##########
@@ -1054,6 +1054,17 @@ function check_download_pendulum() {
     pip check
 }
 
+function uninstall_cassandra_for_python_3_12() {
+    if [[ ${PYTHON_MAJOR_MINOR_VERSION} != "3.12" ]]; then
+        return
+    fi
+    echo
+    echo "${COLOR_BLUE}Uninstalling cassandra in case it was installed via 
cache${COLOR_RESET}"

Review Comment:
   Will this be a permanent thing or shall we have a note with a "open bug 
ticket" to clean this up?
   I assume at some point of time in future cassandra will support 3.12?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to