jscheffl commented on code in PR #38021: URL: https://github.com/apache/airflow/pull/38021#discussion_r1520485421
########## airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts: ########## @@ -62,6 +63,16 @@ export const parseLogs = ( const fileSources: Set<string> = new Set(); const ansiUp = new AnsiUp(); + const urlRegex = /((https?:\/\/|http:\/\/)[^\s]+)/g; + // Detect log groups which can be collapsed + // Either in Github like format '::group::<group name>' to '::endgroup::' + // see https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines + // Or in ADO pipeline like format '##[group]<group name>' to '##[endgroup]' + // see https://learn.microsoft.com/en-us/azure/devops/pipelines/scripts/logging-commands?view=azure-devops&tabs=powershell#formatting-commands + const logGroupStart = / INFO - (::|##\[])group(::|\])([^\n])*/g; + const logGroupEnd = / INFO - (::|##\[])endgroup(::|\])/g; + const logGroupStyle = "color:#0060df;cursor:pointer;font-weight: bold;"; Review Comment: Actually I did not want to hard-code a color here - I just selected the same color like we have with other areas of "blue". Added a comment - if there is a proper/better was to use CSS let me know. Could not find any reasonable way but would like to also offer making it better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
