dirrao commented on code in PR #38048:
URL: https://github.com/apache/airflow/pull/38048#discussion_r1521265124
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -1355,6 +1357,26 @@ def __init__(
self.gcp_conn_id = gcp_conn_id
self.impersonation_chain = impersonation_chain
+ @property
Review Comment:
from where are we going to refer these methods?
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -1328,7 +1330,7 @@ class
DeleteCustomTrainingJobOperator(GoogleCloudBaseOperator):
account from the list granting this role to the originating account
(templated).
"""
- template_fields = ("training_pipeline", "custom_job", "region",
"project_id", "impersonation_chain")
+ template_fields = ("training_pipeline_id", "custom_job_id", "region",
"project_id", "impersonation_chain")
Review Comment:
is this change backward compatible ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]