moiseenkov commented on code in PR #37998:
URL: https://github.com/apache/airflow/pull/37998#discussion_r1521820110


##########
airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -135,6 +144,18 @@ def execute(self, context: Context):
         ti.xcom_push(key="job_name", value=self.job.metadata.name)
         ti.xcom_push(key="job_namespace", value=self.job.metadata.namespace)
 
+        if self.wait_job_until_complete:

Review Comment:
   In this case we could use the `execution_timeout` parameter from the 
`BaseOperator` class. I believe it is more convenient to reuse the existing 
parameter rather than declaring (and maintaining) another one with the same 
logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to