potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524064397
########## docs/apache-airflow-providers-opentelemetry/connections/opentelemetry.rst: ########## @@ -0,0 +1,40 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +.. _howto/connection:opentelemetry: + +OpenTelemetry Connection +============================= + +The OpenTelemetry Connection type enables integrations with the OpenTelemetry endpoint. Review Comment: Are we going to use the Open-Telemetry built-in behaviour also for the built-in metrics generated from Airflow? We had a bit of problem with `smtp` which had similar issue - for provider smtp came with connection, but for the core smtp messages we used the configuration in `config`. Now it's kinda combined - where host/ssl comes from config but credentials come from connection if needed and it's confusing. So I guess here we want to unify it and maybe the otel integration in core should use otel_defailt connection (and maybe there should be a parameter to change where it should be taken from). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
