eladkal commented on code in PR #38222:
URL: https://github.com/apache/airflow/pull/38222#discussion_r1527586858
##########
docs/apache-airflow/administration-and-deployment/priority-weight.rst:
##########
@@ -62,3 +62,17 @@ Below are the weighting methods. By default, Airflow's
weighting method is ``dow
The ``priority_weight`` parameter can be used in conjunction with
:ref:`concepts:pool`.
+
+Experimental Feature
Review Comment:
```suggestion
Custom Priority Weights
```
##########
airflow/models/abstractoperator.py:
##########
@@ -397,11 +399,23 @@ def priority_weight_total(self) -> int:
- WeightRule.DOWNSTREAM - adds priority weight of all downstream tasks
- WeightRule.UPSTREAM - adds priority weight of all upstream tasks
"""
- if self.weight_rule == WeightRule.ABSOLUTE:
+ from airflow.task.priority_strategy import (
+ _AbsolutePriorityWeightStrategy,
+ _DownstreamPriorityWeightStrategy,
+ _UpstreamPriorityWeightStrategy,
+ )
+
+ warnings.warn(
Review Comment:
Why are we deprecating this? Its odd to deprecate something with
experimintal feature as if eventually we decide not to accept it as stable what
would happen to this deprecation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
