LipuFei commented on PR #37143:
URL: https://github.com/apache/airflow/pull/37143#issuecomment-2016490984
@eladkal @potiuk @hussein-awala
Here is a summary of the changes:
- Commit 2d1800aa4afda2f802c44f38a4311576d267fb51 is to check the attribute
`TaskInstance.task` before use.
- Commit 24f118c2848b3ed12b67eede7f5b3bf4d324202e is a refactor to add test:
- `DummySentry` is renamed to `BlankSentry` due to a language check in
GitHub Actions.
- There are two Sentry classes: `BlankSentry` and `ConfiguredSentry`
- `BlankSentry` is a dummy class that does nothing.
- `ConfiguredSentry` actually does Sentry things.
- Initially, both classes are in the `airflow/sentry.py` file. I moved
`BlankSentry` and `ConfiguredSentry` out into two separate files
`airflow/sentry/blank.py` and `airflow/sentry/configured.py`. The two classes
are the same as before. With this refactor, I can directly import
`airflow/sentry/configured.py` and test it. `airflow/sentry/__init__.py` has
the same if-else-block as before.
- Finally, I added a test `tests/test_sentry.py` to test
`ConfiguredSentry.add_tag()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
