ephraimbuddy commented on code in PR #38094:
URL: https://github.com/apache/airflow/pull/38094#discussion_r1537106372


##########
tests/models/test_renderedtifields.py:
##########
@@ -148,6 +170,49 @@ def test_get_templated_fields(self, templated_field, 
expected_rendered_field, da
         # Fetching them will return None
         assert RTIF.get_templated_fields(ti=ti2) is None
 
+    def test_secrets_are_masked_when_large_string(self, dag_maker):
+        """
+        Test that secrets are masked when the templated field is a large string
+        """
+        Variable.set(
+            key="api_key",
+            value="Some very long secret with private information that asserts 
private is not in the rendered field"

Review Comment:
   ```suggestion
               value="Api key secret should be masked as before"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to