tirkarthi commented on PR #38449:
URL: https://github.com/apache/airflow/pull/38449#issuecomment-2020814815

   IMO, making this check for None state also helps in catching issues like 
depends_on_past=True, execution date is in future etc. where task doesn't get 
to scheduled state. After the separate endpoint I also realized the 
implementation has more code than expected initially. I tried timing the check 
and it comes around 2-3 milliseconds with 10 dags so it's not as costly as I 
thought from getting dagbag from airflow app but just had the session based 
subtle issues. So I am open to keeping this as additional field to the existing 
endpoint like first commit or as a separate endpoint or check to be done only 
when passing a query parameter to existing task instance endpoint like 
check_dependencies=True.
   
   
![image](https://github.com/apache/airflow/assets/3972343/e2e7d911-0a44-4477-931b-0a3a38196815)
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to