Lee-W commented on code in PR #38497:
URL: https://github.com/apache/airflow/pull/38497#discussion_r1540645290
##########
airflow/providers/microsoft/azure/hooks/data_lake.py:
##########
@@ -357,10 +357,10 @@ def get_conn(self) -> DataLakeServiceClient: # type:
ignore[override]
credential = conn.password
else:
managed_identity_client_id = self._get_field(extra,
"managed_identity_client_id")
- workload_identity_tenant_id = self._get_field(extra,
"workload_identity_tenant_id")
- credential = AzureIdentityCredentialAdapter(
- managed_identity_client_id=managed_identity_client_id,
- workload_identity_tenant_id=workload_identity_tenant_id,
+ credential = (
Review Comment:
We might also want to add tests like
https://github.com/apache/airflow/blob/bf9bb72bb631c098bfee34a372aefb332c3ffd64/tests/providers/microsoft/azure/hooks/test_data_factory.py#L184C24-L184C57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
