potiuk commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2024146526
> > You should **just** rebase. "Always Be Rebased" as the old Chinese proverb says. > > Who would be kind enough to review this PR? I just can't figure out what's wrong the the docs build... Som indentation issues in your docstrings. Sphinx is very picky about these. You can builds the docs locally with `breeze build-docs` - it will also generate the temporary .rst pages generated from the docstring that you can inspect to check things out. There are few other things (unit tests) : * event_loop seems to be closed where it should not (or at least so the description says) * a connection is defined twice apparently * some warnings are generated when the Hooks are imported * the compatibility checks (or at least some part of them are being fixed in #38545 so you do not have to worry about them until it's merged and you rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
