collinmcnulty commented on code in PR #38505: URL: https://github.com/apache/airflow/pull/38505#discussion_r1544829258
########## docs/apache-airflow/authoring-and-scheduling/timetable.rst: ########## @@ -216,46 +215,47 @@ Timetables comparisons Differences between the two cron timetables ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -There are two timetables `CronTriggerTimetable`_ and `CronDataIntervalTimetable`_ that accepts a cron expression. -There are some differences between the two: -- `CronTriggerTimetable`_ does not take care of *Data Interval*, while `CronDataIntervalTimetable`_ does. -- The time when a DAG run is triggered by `CronTriggerTimetable`_ is more intuitive and more similar to what people -expect cron to behave than that of `CronDataIntervalTimetable`_ (when ``catchup`` is ``False``). +Airflow has two timetables `CronTriggerTimetable`_ and `CronDataIntervalTimetable`_ that accept a cron expression. +However, there are differences between the two: +- `CronTriggerTimetable`_ does not address *Data Interval*, while `CronDataIntervalTimetable`_ does. +- The time when a DAG run is triggered by `CronTriggerTimetable`_ is more similar to how people +expect cron to behave compared to `CronDataIntervalTimetable`_ when ``catchup`` is ``False``. Whether taking care of *Data Interval* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -`CronTriggerTimetable`_ *does not* care the idea of *data interval*. It means the value of ``data_interval_start``, -``data_interval_end`` and legacy ``execution_date`` are the same - the time when a DAG run is triggered. +`CronTriggerTimetable`_ *does not* include *data interval*. This means that the value of ``data_interval_start`` and +``data_interval_end`` (and the legacy ``execution_date``) are the same; the time when a DAG run is triggered. -On the other hand, `CronDataIntervalTimetable`_ *does* care the idea of *data interval*. It means the value of -``data_interval_start`` and ``data_interval_end`` (and legacy ``execution_date``) are different. They are the start -and end of the interval respectively. +However, `CronDataIntervalTimetable`_ *does* include *data interval*. This means the value of +``data_interval_start`` and ``data_interval_end`` (and legacy ``execution_date``) are different. ``data_interval_start`` is the time when a +DAG run is triggered and ``data_interval_end`` is the end of the interval. The time when a DAG run is triggered ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -There is no difference between the two when ``catchup`` is ``True``. :ref:`dag-catchup` tells you how DAG runs are +There is no difference between `CronTriggerTimetable`_ and `CronDataIntervalTimetable`_ when ``catchup`` is ``True``. :ref:`dag-catchup` tells you how DAG runs are Review Comment: I think this is actually not true. All the points listed in catchup=False sections are applicable when catchup=False too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
