pankajkoti commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545612812


##########
.github/workflows/push-image-cache.yml:
##########
@@ -76,7 +75,7 @@ on:  # yamllint disable-line rule:truthy
 jobs:
   push-ci-image-cache:
     name: "Push CI ${{ inputs.cache-type }}:${{ matrix.python }} image cache "
-    runs-on: ${{ fromJSON(inputs.runs-on) }}
+    runs-on: ${{ fromJSON(inputs.runs-on-as-string) }}

Review Comment:
   ```suggestion
       runs-on: ${{ fromJSON(inputs.public-runs-on-as-string) }}
   ```
   Based on the previous comment if we decide to accept the previous comment.



##########
.github/workflows/push-image-cache.yml:
##########
@@ -134,7 +133,7 @@ jobs:
 
   push-prod-image-cache:
     name: "Push PROD ${{ inputs.cache-type }}:${{ matrix.python }} image cache"
-    runs-on: ${{ fromJSON(inputs.runs-on) }}
+    runs-on: ${{ fromJSON(inputs.runs-on-as-string) }}

Review Comment:
   ```suggestion
       runs-on: ${{ fromJSON(inputs.public-runs-on-as-string) }}
   ```
   Based on the previous comment if we decide to accept the previous comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to