o-nikolas commented on code in PR #38514:
URL: https://github.com/apache/airflow/pull/38514#discussion_r1540104792
##########
airflow/jobs/job.py:
##########
@@ -104,12 +105,13 @@ class Job(Base, LoggingMixin):
Only makes sense for SchedulerJob and BackfillJob instances.
"""
- def __init__(self, executor=None, heartrate=None, **kwargs):
+ def __init__(self, executor: BaseExecutor | None = None, heartrate=None,
**kwargs):
# Save init parameters as DB fields
self.heartbeat_failed = False
self.hostname = get_hostname()
if executor:
self.executor = executor
+ self.executors = [executor]
Review Comment:
In reality the `executor` parameter to `__init__` isn't used in production,
so I didn't add an `executors` field to match it. To cover the tests that use
it, I just take `executor` and update the `executors` field with that input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
