ferruzzi opened a new issue, #38655:
URL: https://github.com/apache/airflow/issues/38655

   ### Apache Airflow version
   
   2.9.0b2
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   When OTel support was added, it enabled adding tags to metrics.  Metrics 
such as `ti.start.<dag_id>.<task_id>` became `ti.start` with the tags for 
`dag_id` and `task_id`.  Statsd does not support tagging, so all metrics had to 
be emitted twice; once with tagging and once assembled as a single long name.  
Over time, we've forgotten this and some newer metrics have been added which 
only emit one way or the other.    
   
   ### What you think should happen instead?
   
   I propose that airflow.metrics.statd_logger should be modified to assemble 
the name and tags into a long name, then any and all double-emitted metrics can 
be consolidated and future metrics can be easier and more consistently 
implemented.
   
   ### How to reproduce
   
   Example of some "double-emitted" metrics:
   
![image](https://github.com/apache/airflow/assets/1920178/f769b546-0cde-4bd1-a072-1753708544d6)
   
   
   in this case, statsd.incr() accepts the tags but does nothing with them.  If 
it did a `("_").join(name, tags)` before emitting, then we could drop the 
redundant metric and simplify future additions.
   
   ### Operating System
   
   nix
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to