uranusjr commented on code in PR #38565:
URL: https://github.com/apache/airflow/pull/38565#discussion_r1547110943


##########
airflow/models/renderedtifields.py:
##########
@@ -50,6 +50,12 @@
     from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
 
 
+def _get_fields(ti):

Review Comment:
   This should have a better name to describe what the function does. 
`get_serialized_template_fields` maybe? It’s also better for this to take a 
`task: Operator` instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to