Taragolis commented on code in PR #38665:
URL: https://github.com/apache/airflow/pull/38665#discussion_r1548183906
##########
tests/system/conftest.py:
##########
@@ -49,9 +49,9 @@ def skip_if_env_var_not_set(provider_env_vars):
def pytest_collection_modifyitems(config, items):
"""Add @pytest.mark.system(provider_name) for every system test."""
- rootdir = Path(config.rootdir)
+ rootdir = Path(config.rootpath)
Review Comment:
For avoid guessing, what the return by specific attributes there is
[`pytest.Config`
API](https://docs.pytest.org/en/latest/reference/reference.html#pytest.Config)
Not a big deal to wrap `pathlib.Path` by subclass of `pathlib.Path`, time to
time we even do it in Airflow codebase, so if someone want to fix it, as well
as add type annotations into the hook input attributes, it could be done in
follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
