potiuk commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1548320952
##########
airflow/jobs/job.py:
##########
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
- def is_alive(self, grace_multiplier=2.1) -> bool:
+ def is_alive(self) -> bool:
"""
Is this job currently alive.
We define alive as in a state of RUNNING, and having sent a heartbeat
within a multiple of the heartrate (default of 2.1)
-
- :param grace_multiplier: multiplier of heartrate to require heart beat
- within
"""
+ threshold_value = health_check_threshold(
+ self.job_type, self.heartrate, self.grace_multiplier
Review Comment:
Yeah. That's the problem when we try to add parameters to a DB models that
are not DB fields.
I think it's best to just remove the grace multiplier from init param and
leave 2.1 as default value in "health_check_threshold" method (and do not pass
any multiplier there - leave the default one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
