potiuk opened a new pull request, #38764:
URL: https://github.com/apache/airflow/pull/38764

   While preparing for presentation about modernizing packaging setup I found 
out that we can slightly improve editable installation of airflow. So far we 
required a "devel" installation in order to make a working editable 
installation of airflow (because the devel extra was installing dependencies 
for all the pre-installed providers).
   
   However that required to synchronize the list of providers installed in 
`devel` dependency with the list of preinstalled providers, as well as it made 
`pip install -e .` resulting with a non-working version of Airflow (because it 
requires `fab` provider dependencies to start airflow webserver).
   
   This PR improves it - in editable mode, instead of adding the pre-installed 
providers, we add their dependencies. This way we can remove the pre-installed 
providers from the list of devel providers to install - because now the 
pre-installed provider dependencies are installed simply as "required" 
dependencies.
   
   As a result - simple `pip install -e .` should now result in fully working 
airflow installation - without all the devel goodies and without celery and 
kubernetes dependencies, but fully usable for sequential and local executor 
cases.
   
   Also reviewed and updated the comments in hatch_build.py to better reflect 
the purpose and behaviour of some of the methods there.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to