e-galan commented on code in PR #37693:
URL: https://github.com/apache/airflow/pull/37693#discussion_r1553622795
##########
airflow/providers/google/cloud/sensors/dataflow.py:
##########
@@ -151,12 +205,14 @@ def __init__(
self,
*,
job_id: str,
- callback: Callable[[dict], bool],
+ callback: Callable | None = None,
Review Comment:
@Lee-W
For `DataflowJobStatusSensor` it is just wrong because the execute method
will not return any dicts, only booleans or exceptions.
Also, because the callback function can be completely arbitrary, I don't
think it even makes sense to put such typing constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
