ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1555877716
##########
airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
def _auth_aws_iam(self, _client: hvac.Client) -> None:
- if self.auth_mount_point:
+ if self.key_id or self.secret_id or self.role_id:
_client.auth.aws.iam_login(
access_key=self.key_id,
secret_key=self.secret_id,
role=self.role_id,
mount_point=self.auth_mount_point,
)
- else:
- _client.auth.aws.iam_login(access_key=self.key_id,
secret_key=self.secret_id, role=self.role_id)
+ elif self.aws_conn_id:
Review Comment:
Thanks Pankaj. My understanding is that it is the standard is to configure
and manage all Secrets Backend configurations in `backend_kwargs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
