vincbeck commented on code in PR #39254:
URL: https://github.com/apache/airflow/pull/39254#discussion_r1579615508
##########
airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -232,14 +231,15 @@ class
FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
(permissions.ACTION_CAN_ACCESS_MENU, permissions.RESOURCE_DOCS),
(permissions.ACTION_CAN_ACCESS_MENU, permissions.RESOURCE_DOCS_MENU),
(permissions.ACTION_CAN_ACCESS_MENU, permissions.RESOURCE_JOB),
- (permissions.ACTION_CAN_ACCESS_MENU, permissions.RESOURCE_PLUGIN),
(permissions.ACTION_CAN_ACCESS_MENU, permissions.RESOURCE_SLA_MISS),
(permissions.ACTION_CAN_ACCESS_MENU,
permissions.RESOURCE_TASK_INSTANCE),
]
# [END security_viewer_perms]
# [START security_user_perms]
USER_PERMISSIONS = [
+ (permissions.ACTION_CAN_ACCESS_MENU, permissions.RESOURCE_PLUGIN),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_PLUGIN),
Review Comment:
I would move it to `OP_PERMISSIONS`. It should not belong to user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
