dondaum commented on code in PR #39293: URL: https://github.com/apache/airflow/pull/39293#discussion_r1582363450
########## airflow/providers/fab/auth_manager/security_manager/override.py: ########## @@ -1506,14 +1506,15 @@ def add_user( user.username = username user.email = email user.active = True + self.get_session.add(user) Review Comment: This fixes the SQA 2.0 warning however I think we might could / should leave it as it is. SQA 2.0 complains about the User object that is being merged into a Session along the backref cascade. In SQA 2.0 this won't happen. But we add the User object explicit to session so IMO we should be fine without the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org