potiuk commented on a change in pull request #5786: [AIRFLOW-5170]
[AIRFLOW-5256] Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r320021010
##########
File path:
airflow/migrations/versions/33ae817a1ff4_add_kubernetes_resource_checkpointing.py
##########
@@ -44,11 +44,11 @@ def upgrade():
conn = op.get_bind()
# alembic creates an invalid SQL for mssql and mysql dialects
- if conn.dialect.name in ("mysql"):
+ if conn.dialect.name in {"mysql"}:
Review comment:
In this particular case my "guess" was right:
The "in" condition was manually added in this commit when mssql support was
added:
https://github.com/apache/airflow/commit/d03cc1784b3bb0d33dfd62d451f495144f7b4af7
It was added as tuple in another file: and then limited to mssql only with
tuple's comma lost along the way :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
