Taragolis commented on code in PR #39090:
URL: https://github.com/apache/airflow/pull/39090#discussion_r1589966005


##########
tests/conftest.py:
##########
@@ -905,6 +906,12 @@ def __call__(
                 else:
                     DEFAULT_DATE = timezone.datetime(2016, 1, 1)
                     self.start_date = DEFAULT_DATE
+
+            # Handle deprecated argument `concurrency` for DAG class
+            # If "concurrency" is defined, replace it with "max_active_tasks"
+            if concurrency:
+                self.kwargs["max_active_tasks"] = concurrency
+                self.kwargs.pop("concurrency")

Review Comment:
   I think it could be resolved pretty easy, at least same things we do when 
try to resolve
   
   - You add a raise en error
   - I've add `full test needed` label and restart workflow
   - We retrieve list of all tests where it failed
   - After 1 or 2 iteration it could be finally resolved
   
   This only about a tests, so we do not need to deprecate it into the tests, 
because tests do not have any versions and could be changed in any time, and 
better change it as soon as it possible for avoid situation, that we forget 
about this changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to