pankajkoti commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1590734592
##########
airflow/providers/pinecone/operators/pinecone.py:
##########
@@ -119,7 +119,7 @@ def __init__(
pod_type: str | None = None,
metadata_config: dict | None = None,
source_collection: str | None = None,
- metric: str | None = None,
+ metric: str | None = "cosine",
Review Comment:
Same question here. If `None` is an acceptable value, then why are we
defaulting to "cosine"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
