jedcunningham commented on code in PR #38697:
URL: https://github.com/apache/airflow/pull/38697#discussion_r1594326160
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -104,8 +104,17 @@ spec:
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
resources: {{- toYaml .Values.statsd.resources | nindent 12 }}
- {{- with .Values.statsd.env }}
- env: {{- toYaml . | nindent 12 }}
+ env:
+ {{- if .Values.statsd.env }}
+ {{- toYaml .Values.statsd.env | nindent 12 }}
+ {{- end }}
+ {{- if .Values.config.metrics.metrics_allow_list }}
+ - name: AIRFLOW__METRICS__METRICS_ALLOW_LIST
Review Comment:
We shouldn't inject these env vars just to cause a restart. Annotations is
the "right way" to cause that behavior.
That said, this is just how the statsd world behaves by default. e.g.
[deleteIdleStats in StatsD
itself](https://github.com/statsd/statsd/blob/7c07eec4e7cebbd376d8313b230cea96c6571423/exampleConfig.js#L61C3-L63).
I believe the equivalent is [ttl in
statsd-exporter](https://github.com/prometheus/statsd_exporter/blob/58769c7b4d128e7ceae1cf8d893260ed5b5afa4d/README.md?plain=1#L442).
You can probably set it with `statsd.overrideMappings`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
