potiuk commented on code in PR #39371:
URL: https://github.com/apache/airflow/pull/39371#discussion_r1595380774
##########
airflow/providers/apache/beam/triggers/beam.py:
##########
@@ -233,6 +235,22 @@ async def run(self) -> AsyncIterator[TriggerEvent]: #
type: ignore[override]
if is_running:
await asyncio.sleep(self.poll_sleep)
try:
+ # Creating a new event loop to manage I/O operations asynchronously
Review Comment:
BTW. I see it was copied from the previous implementation but it might be
good to clarify and possibly fix it to use get_running_loop() (and fix the
comment) if that's what is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
