potiuk commented on code in PR #39513:
URL: https://github.com/apache/airflow/pull/39513#discussion_r1595995895
##########
tests/listeners/class_listener.py:
##########
@@ -47,9 +47,7 @@ def on_task_instance_success(self, previous_state,
task_instance, session):
self.state.append(TaskInstanceState.SUCCESS)
@hookimpl
- def on_task_instance_failed(
- self, previous_state, task_instance, error: None | str |
BaseException, session
- ):
+ def on_task_instance_failed(self, previous_state, task_instance, session):
Review Comment:
@mobuchowski @vandonr -> I think there is a problem with the way how we
extended the listener. I had to revert the change of yours from #38155 to make
the current tests work at all with airflow 2.9.1 installed from PyPI -
otherwise it failed with mismatched specification and implementation. I think
we should double check what's going on here, but it looks like the way the
interface is extended, it's not working as expected for old Airflow version.
I will provide some more discussion and way to reproduce it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
