ferruzzi commented on code in PR #39500:
URL: https://github.com/apache/airflow/pull/39500#discussion_r1598804403


##########
tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py:
##########
@@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str):
     )
     # [END howto_sensor_bedrock_ingest_data]
 
+    # [START howto_operator_bedrock_retrieve_and_generate]
+    retrieve_and_generate = BedrockRaGOperator(
+        task_id="retrieve_and_generate",
+        input="Who was the CEO of Amazon on 2022?",
+        source_type="KNOWLEDGE_BASE",

Review Comment:
   While adding this I found out that “external sources” was only added to the 
API 3 weeks ago, meaning it would need botocore min version 1.34.103 current 
dependency is botocore>=1.33.0 which leaves us with an awkward situation.  We 
can bump minver on botocore but forcing a 3-week-old version feels aggressive.  
   
   We don't usually do this, but I think in this case maybe wrapping it in a 
botocore version check and adding a note inthe docs may be the right call?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to