josh-fell commented on code in PR #39599: URL: https://github.com/apache/airflow/pull/39599#discussion_r1599328193
########## airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py: ########## @@ -94,8 +97,8 @@ def __init__( self.share_name = share_name self.directory_path = directory_path self.directory_name = directory_name - if self.directory_path is None: - self.directory_path = directory_name + if self.directory_path is None and self.directory_name is not None: Review Comment: Technically `directory_path` (and `directory_name`) are optional. The warning would be emitted even if a user purposely did not wish to specify `directory_name`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org