dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605193809
##########
airflow/models/taskinstance.py:
##########
@@ -2709,43 +3004,12 @@ def _execute_task(self, context: Context, task_orig:
Operator):
return _execute_task(self, context, task_orig)
@provide_session
- def defer_task(self, session: Session, defer: TaskDeferred) -> None:
+ def defer_task(self, exception: TaskDeferred, session: Session) -> None:
Review Comment:
because defer doesn't really have an obvious meaning....
the thing that's being passed is the exception object. so it felt a little
clearer to me to do this.
but it's not really necessary, and i could do this in a separate PR. but i
figured it's ok cus i think it's marked :meta private:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
