gerardo commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r320533402
########## File path: Dockerfile ########## @@ -372,4 +397,6 @@ EXPOSE 8080 ENTRYPOINT ["/usr/local/bin/dumb-init", "--", "/entrypoint.sh"] +VOLUME /var/lib/docker Review comment: I'll add a comment, but essentially, for docker-in-docker to work: >The Dockerfile also indicates that /var/lib/docker should be a volume. This is important, because the filesystem of a container is an AUFS mountpoint, composed of multiple branches; and those branches have to be “normal” filesystems (i.e. not AUFS mountpoints). In other words, /var/lib/docker, the place where Docker stores its containers, **cannot be an AUFS filesystem**. Therefore, we instruct Docker that this path should be a volume. Volumes have many purposes, but in this scenario, we use them as a pass-through to the “normal” filesystem of the host machine. The /var/lib/docker directory of the nested Docker will live somewhere in /var/lib/docker/volumes on the host system.` Reference: https://blog.docker.com/2013/09/docker-can-now-run-within-docker/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
