aptenodytes-forsteri commented on code in PR #39694:
URL: https://github.com/apache/airflow/pull/39694#discussion_r1608675167
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -618,7 +615,8 @@ def await_pod_completion(
remote_pod = self.read_pod(pod)
if remote_pod.status.phase in PodPhase.terminal_states:
break
- if istio_enabled and container_is_completed(remote_pod,
container_name):
+ if container_is_completed(remote_pod, container_name):
+ self.log.info("Base container %s has completed",
container_name)
Review Comment:
Working around this issue, I added a 30 second timeout after this condition
is met to see if the sidecar container exits normally. Without the 30 second
timeout, I was seeing cases where the sidecar was being terminated before
gracefully exiting and that seemed to cause some errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
