ephraimbuddy commented on code in PR #38423:
URL: https://github.com/apache/airflow/pull/38423#discussion_r1609533227


##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -213,6 +216,21 @@ def format_url(host: str) -> str:
 
         return host
 
+    def _get_index_patterns(self, ti: TaskInstance | None) -> str:
+        """
+        Get index patterns by calling index_patterns_callable, if provided, or 
the configured index_patterns.
+
+        :param ti: A TaskInstance object or None.
+        """
+        if self.index_patterns_callable:
+            self.log.debug("Using index_patterns_callable: %s", 
self.index_patterns_callable)
+            module_path, index_pattern_function = 
self.index_patterns_callable.rsplit(".", 1)

Review Comment:
   We should use `import_string` from airflow.utils.module_loading` for better 
error handling



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to