utkarsharma2 commented on code in PR #38423:
URL: https://github.com/apache/airflow/pull/38423#discussion_r1609709279
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -152,7 +153,8 @@ def __init__(
offset_field: str = "offset",
host: str = "http://localhost:9200",
frontend: str = "localhost:5601",
- index_patterns: str | None = conf.get("elasticsearch",
"index_patterns", fallback="_all"),
+ index_patterns: str = conf.get("elasticsearch", "index_patterns"),
+ index_patterns_callable: str = conf.get("elasticsearch",
"index_patterns_callable", fallback=""),
Review Comment:
IMO, If it always comes from a config file, we can remove it as a param?
Otherwise, devs can still use and create the class object passing it. I see no
harm in adding it to docs.
But TBH I'm not sure what the norm is here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]