e-galan commented on code in PR #39752:
URL: https://github.com/apache/airflow/pull/39752#discussion_r1611230665


##########
tests/providers/google/cloud/operators/test_automl.py:
##########
@@ -379,63 +379,51 @@ def test_templating(self, 
create_task_instance_of_operator):
         assert task.impersonation_chain == "impersonation-chain"
 
 
-class TestAutoMLListColumnsSpecsOperator:
+class TestAutoMLTablesListColumnsSpecsOperator:
+    expected_deprecation_warning = (
+        "Class `AutoMLTablesListColumnSpecsOperator` has been deprecated and 
will be removed after 31.12.2024. "
+        "AutoML platform no longer supports tabular datasets after its 
integration with Cloud Translation and Vertex AI. "
+        "Please refer to 
https://cloud.google.com/vertex-ai/docs/start/migrating-to-vertex-ai and "
+        "https://cloud.google.com/translate/docs/advanced/automl-upgrade for 
more info about available alternatives."
+    )
+
     
@mock.patch("airflow.providers.google.cloud.operators.automl.CloudAutoMLHook")
     def test_execute(self, mock_hook):
         table_spec = "table_spec_id"
         filter_ = "filter"
         page_size = 42
 
-        op = AutoMLTablesListColumnSpecsOperator(
-            dataset_id=DATASET_ID,
-            table_spec_id=table_spec,
-            location=GCP_LOCATION,
-            project_id=GCP_PROJECT_ID,
-            field_mask=MASK,
-            filter_=filter_,
-            page_size=page_size,
-            task_id=TASK_ID,
-        )
-        op.execute(context=mock.MagicMock())
-        mock_hook.return_value.list_column_specs.assert_called_once_with(
-            dataset_id=DATASET_ID,
-            field_mask=MASK,
-            filter_=filter_,
-            location=GCP_LOCATION,
-            metadata=(),
-            page_size=page_size,
-            project_id=GCP_PROJECT_ID,
-            retry=DEFAULT,
-            table_spec_id=table_spec,
-            timeout=None,
-        )
+        with pytest.raises(AirflowProviderDeprecationWarning, 
match=self.expected_deprecation_warning):

Review Comment:
   @Taragolis I see that you already responded in #38673 , I will stick to the 
2nd approach and refactor all 4 AutoML operators: 
`AutoMLTablesUpdateDatasetOperator`, `AutoMLDeployModelOperator`, 
`AutoMLTablesListTableSpecsOperator`, `AutoMLTablesListColumnSpecsOperator`. 
   
   Since the 4 operators can no longer be used, as the corresponding AutoML 
services have reached their EOL in March 2024, it means that it is too late to 
"deprecate" them normally. We need to tell the users to not use them. So I will 
remove the `deprecated` decorator completely and add Airflow exceptions into 
their `__init__` methods.  
   
   I hope you are ok with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to