sanket2000 commented on code in PR #39823:
URL: https://github.com/apache/airflow/pull/39823#discussion_r1615158404
##########
airflow/sensors/base.py:
##########
@@ -322,7 +322,7 @@ def run_duration() -> float:
raise AirflowRescheduleException(reschedule_date)
else:
time.sleep(self._get_next_poke_interval(started_at,
run_duration, poke_count))
- poke_count += 1
+ poke_count += 1
Review Comment:
> or infer it from existing information.
I think this should be the solution to this problem, we remove the
poke_count (or try_number) from the execute function altogether, and estimate
the try number based on available information such as start_date and
run_duration (or duration from TaskReshedule). If someone can review this logic
and give feedback that would be helpful.
for now ill push a change to this PR as a proposed solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
