ThomasThelen opened a new issue, #39860:
URL: https://github.com/apache/airflow/issues/39860

   ### Apache Airflow Provider(s)
   
   neo4j
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Apache Airflow version
   
   2.9.0
   
   ### Operating System
   
   macOS
   
   ### Deployment
   
   Docker-Compose
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   The Neo4jOperator makes reference to executing sql, when the actual query 
language is cypher. SQL is not used to query graph databases, and Neo4j doesn't 
support SQL.
   
   This was confusing to me because I had to make sure that the operator in 
fact, was using CYPHER instead of sql.
   
   The example 
[here](https://airflow.apache.org/docs/apache-airflow-providers-neo4j/stable/_modules/tests/system/providers/neo4j/example_neo4j.html)
 uses CYPHER, but passes it into the `sql` kwarg which is 
confusing/misleading/incorrect.
   
   ### What you think should happen instead
   
   Instead of the operator taking a `sql` kwarg it should be renamed to cypher 
to match the actual query language being used.
   
   ### How to reproduce
   
   Reproduce by looking at the source 
https://github.com/apache/airflow/blob/main/airflow/providers/neo4j/operators/neo4j.py#L31
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to