Re: [PR] Improve trigger UI for string array format validation [airflow]

[via GitHub]

techolga commented on code in PR #39993:
URL: https://github.com/apache/airflow/pull/39993#discussion_r1623650895


##########
airflow/www/static/js/trigger.js:
##########
@@ -137,6 +137,14 @@ function initForm() {
           });
           field.on("blur", updateJSONconf);
           objectFields.set(elements[i].name, field);
+        } else if (
+          elements[i].attributes.valuetype &&
+          elements[i].attributes.valuetype.value === "array"
+        ) {
+          if (elements[i].value) {
+            elements[i].value = JSON.parse(elements[i].value).join("\n");

Review Comment:
   This is to handle the input in case of a failed validation. The input is put 
back into the field but if its not formatted back to an string the textarea 
renders the raw json array
   
![image](https://github.com/apache/airflow/assets/36713373/008d51b9-c626-4eb4-aa50-e12bf577db0f)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org