uranusjr commented on PR #37028:
URL: https://github.com/apache/airflow/pull/37028#issuecomment-2144241883

   The idea looks fine to me, but this should be a part of 
`_do_render_template_fields` instead, or even somewhere deeper in the call 
chain. `render_template_fields` is an override point for users and we shouldn’t 
put logic in there where people can shadow.
   
   I wonder if we should make this a part of `render_template`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to