leakec commented on PR #40035: URL: https://github.com/apache/airflow/pull/40035#issuecomment-2146435716
@o-nikolas I'm very unfamiliar with the airflow test case suite (I'm new to airflow in general), so I doubt I'll get much further in terms of writing a test without a significant time sink. Similarly, I wasn't sure if there were any cases where `AttributeError` could still be raised, it didn't look like that to me, but I left both in there just in case, i.e., #40012 catches both exception types rather than replacing `AttributeError` with `TypeError`. If `AttributeError` will not be thrown and `TypeError` is the one that will always be raised here (looks like that to me), then this PR is a better fix than #40012, and it has a test case, which #40012 does not. If this test case captures everything (to me it looks like it does), then I think we should just close #40012 without merging and merge this one instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
