shubham22 commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625250272
##########
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##########
@@ -667,6 +672,31 @@ class TestGetTaskInstances(TestTaskInstanceEndpoint):
2,
id="test queue filter ~",
),
+ pytest.param(
+ [
+ {"executor": "test_exec_1"},
+ {"executor": "test_exec_2"},
+ {"executor": "test_exec_3"},
Review Comment:
I see that you don't use test_exec_3 anywhere later, was that intentional?
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -4943,6 +4956,11 @@ components:
items:
type: string
description: The value can be repeated to retrieve multiple matching
values (OR condition).
+ executor:
Review Comment:
you do allow multiple executors to be filtered at once, right? If so, should
it names "executors"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
