ashb commented on code in PR #39951:
URL: https://github.com/apache/airflow/pull/39951#discussion_r1633446647


##########
airflow/migrations/versions/0146_2_10_0_add_task_instance_history.py:
##########
@@ -86,10 +88,6 @@ def upgrade():
             ],
             name="task_instance_history_ti_fkey",
             ondelete="CASCADE",
-            onupdate="CASCADE",
-        ),
-        sa.PrimaryKeyConstraint(
-            "dag_id", "task_id", "run_id", "map_index", "try_number", 
name="task_instance_history_pkey"

Review Comment:
   We should add a unique constraint now that we've removed the PK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to