uranusjr commented on code in PR #40156:
URL: https://github.com/apache/airflow/pull/40156#discussion_r1634196672
##########
airflow/serialization/serialized_objects.py:
##########
@@ -847,10 +847,10 @@ def _serialize_params_dict(cls, params: ParamsDict |
dict):
return serialized_params
@classmethod
- def _deserialize_params_dict(cls, encoded_params: dict) -> ParamsDict:
+ def _deserialize_params_dict(cls, encoded_params: list) -> ParamsDict:
"""Deserialize a DAG's Params dict."""
op_params = {}
- for k, v in encoded_params.items():
+ for k, v in dict(encoded_params).items():
Review Comment:
Ah or is this so we can handle both the old and new cases? Converting to
dict seems unnecessary to me though. Maybe
```python
if isinstance(encoded_params, collections.abc.Mapping):
encoded_param_pairs = encoded_params.items()
else:
encoded_param_pairs = encoded_params
for k, v in encoded_param_pairs:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
