Lee-W commented on code in PR #39585:
URL: https://github.com/apache/airflow/pull/39585#discussion_r1634503025
##########
airflow/models/taskinstance.py:
##########
@@ -1575,12 +1575,29 @@ def _coalesce_to_orm_ti(*, ti: TaskInstancePydantic |
TaskInstance, session: Ses
@internal_api_call
@provide_session
def _defer_task(
- ti: TaskInstance | TaskInstancePydantic, exception: TaskDeferred, session:
Session = NEW_SESSION
+ ti: TaskInstance | TaskInstancePydantic,
+ exception: TaskDeferred | None = None,
+ session: Session = NEW_SESSION,
) -> TaskInstancePydantic | TaskInstance:
from airflow.models.trigger import Trigger
+ if exception is not None:
+ trigger_row = Trigger.from_object(exception.trigger)
+ trigger_kwargs = exception.kwargs
+ next_method = exception.method_name
+ timeout = exception.timeout
+ elif ti.task is not None and ti.task.start_trigger_args is not None:
+ trigger_row = Trigger(
+ classpath=ti.task.start_trigger_args.trigger_cls,
+ kwargs=ti.task.start_trigger_args.trigger_kwargs or {},
+ )
+ trigger_kwargs = ti.task.start_trigger_args.trigger_kwargs
Review Comment:
As this is handled in line 1615, I think we're good to keep it as it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
