potiuk commented on code in PR #40266:
URL: https://github.com/apache/airflow/pull/40266#discussion_r1641617007


##########
contributing-docs/03_contributors_quick_start.rst:
##########
@@ -466,6 +466,11 @@ on macOS, install via
 
 2. Installing required Python packages
 
+.. note::
+  If pyenv and pyenv-virtualenv are not installed, install them first.

Review Comment:
   Pyenv is just one of the ways you can install and activate venv. However I 
think we should likely change those instructions to use `pipx`. Pre-commit is 
better to be Installed via `pipx` as it will create and manage it's venv 
automatically. Would you like to change your PR and test it locally with pic 
instead? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to