o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644788180
##########
tests/jobs/test_backfill_job.py:
##########
@@ -139,14 +167,14 @@ def test_unfinished_dag_runs_set_to_failed(self,
dag_maker):
assert State.FAILED == dag_run.state
- def test_dag_run_with_finished_tasks_set_to_success(self, dag_maker):
+ def test_dag_run_with_finished_tasks_set_to_success(self, dag_maker,
mock_executor):
Review Comment:
Many of the tests actually do use the object, which is why it is yielded
from the fixture. And to me I think it is actually quite common to see a
fixture being used without using the object it yields, you'll see this across
the Airflow code base and many others.
I don't want to use auto-use since not all tests need or want the executor
mocked in this way (autouse can be a source of great confusion when writing
tests and you're not sure why the behaviour doesn't match your expectations).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
