pankajkoti commented on code in PR #40141:
URL: https://github.com/apache/airflow/pull/40141#discussion_r1644860673
##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -313,9 +313,14 @@ def _manage_executor_state(
and ti.state in self.STATES_COUNT_AS_RUNNING
):
msg = (
- f"Executor reports task instance {ti} finished ({state})
although the task says its "
- f"{ti.state}. Was the task killed externally? Info: {info}"
+ f"The executor reported that the task instance {ti}
finished with state {state}, "
+ f"but the task instance's state attribute is {ti.state}. "
+ "This indicates that the task was marked failed by
something other than the scheduler. "
Review Comment:
I am wondering if instead of saying ".....something other than the
scheduler," it should be phrased as "something other than the worker/pod that
is actually running the task," or something similar. The scheduler is still an
external component and is responsible for failing tasks that are timed out
while being stuck in the queue or detecting and killing zombie tasks. In fact,
it is the scheduler that marks them as failed, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
