jedcunningham commented on code in PR #40333:
URL: https://github.com/apache/airflow/pull/40333#discussion_r1649460720
##########
chart/templates/_helpers.yaml:
##########
@@ -224,27 +224,30 @@ If release name contains chart name it will be used as a
full name.
value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
+ {{- if semverCompare "<v4.0.0" .Values.images.gitSync.tag }}
Review Comment:
Okay, I see what's going on.
> Could we require one of the pairs, and automate the other?
That would be relatively easy, yeah. We'd just pick, probably the v3 form
since that's been around and working, and expect the key to be that in the
sercet.
> Or set them all to `optional: true`
I'm good that with too.
I think originally it was intended for folks to set both the v3 and v4 forms
in the secret, but that's with the benefit of hindsight and I would have also
just done the v4 first...
I think the v3 key in the secret only approach is a bit cleaner, so I'd
probably lean that way?
##########
chart/templates/_helpers.yaml:
##########
@@ -224,27 +224,30 @@ If release name contains chart name it will be used as a
full name.
value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
+ {{- if semverCompare "<v4.0.0" .Values.images.gitSync.tag }}
Review Comment:
Okay, I see what's going on.
> Could we require one of the pairs, and automate the other?
That would be relatively easy, yeah. We'd just pick, probably the v3 form
since that's been around and working, and expect the key to be that in the
sercet.
> Or set them all to `optional: true`
I'm good that with too.
I think originally it was intended for folks to set both the v3 and v4 forms
in the secret, but that's with the benefit of hindsight and as a user, I would
have also just done the v4 first too...
I think the v3 key in the secret only approach is a bit cleaner, so I'd
probably lean that way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
